Add configuration for check-wheel-contents
#976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utility `check-wheel-contents` is useful for checking that wheels are constructed correctly; however, it generates false positives because it doesn’t know about how `cibuildwheel` adds object files to wheels.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds configuration for the check-wheel-contents tool in pyproject.toml. The change is to ignore warnings W009 and W010, which are described as false positives resulting from how cibuildwheel packages compiled object files. The change is clear, well-justified, and correctly implemented. I have reviewed the code and found no issues.
Collaborator
Author
|
After further thought, closing this PR. This should only be added if/after check-wheel-contents is used in a script or workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility
check-wheel-contentsis useful for checking that wheels are constructed correctly; however, it generates false positives because it doesn’t know about howcibuildwheeladds object files to wheels.